apply the crc target feature to the acle crc32 implementation#294
Merged
folkertdev merged 1 commit intomainfrom Feb 18, 2025
Merged
apply the crc target feature to the acle crc32 implementation#294folkertdev merged 1 commit intomainfrom
crc target feature to the acle crc32 implementation#294folkertdev merged 1 commit intomainfrom
Conversation
folkertdev
force-pushed
the
acle-target-feature
branch
from
004107e to
a34a485
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
bjorn3
reviewed
Feb 18, 2025
bjorn3
approved these changes
Feb 18, 2025
folkertdev
force-pushed
the
acle-target-feature
branch
from
a34a485 to
93f5031
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The target feature is required for inlining the intrinsics on
aarch64-unknown-linux-gnu. For the apple targets it looks like the crc feature is on by default and therefore this change won't have any effect there.I also removed support for
arm, which was not hooked up (and I believe the related target features are unstable).